Skip to content

Add principal grid orientation of the algorithm as an explicit parameter

Aleksei KALINOV requested to merge algorithm_orientation into master

Add principal grid orientation of the algorithm as an explicit parameter

So far all our modules assumed that the grid is operating on a single direction. Specifically, we assumed that all operations are direction independent and it is enough to use direction 0 to perform all operations. During investigation of issue #1 (closed) I found out that the labeling can be inconsistent from different directions.

In light of these facts, the following contains two changes:

  1. The orientation parameter is made explicit. This shows in the code where our assumptions about the direction manifest. So far, user cannot control it but it can be made accessible quite easily.
  2. The labeling for the grid is computed from all 3 sides. So far, no action is made when the labels are different, so the behavior is identical to the previous version but lays the foundation for further changes in how these inconsistencies are detected and resolved.

Merge request reports